Skip to content

chore: If selecting an unhealthy proxy, default to primary #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 9, 2023

What this does

Default to primary if the selectedProxy is unhealthy. Wrote a unit test to confirm this works.

Fixes: #7443

@Emyrk Emyrk requested a review from Kira-Pilot May 9, 2023 14:51
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Emyrk Emyrk merged commit fb86ac2 into main May 10, 2023
@Emyrk Emyrk deleted the stevenmasley/fix_primary_port_forward branch May 10, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace proxies: "port forward" dialog doesn't show up if you had previously selected an unhealthy moon
2 participants