Skip to content

feat: add deleted_at field to workspace model #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2023

Conversation

Kira-Pilot
Copy link
Member

@Kira-Pilot Kira-Pilot commented May 9, 2023

Screenshot 2023-05-09 at 5 36 13 PM

deleted_at is a calculated field on the workspace model that will return a time.Time if a workspace is scheduled for deletion. Workspaces are scheduled for deletion when the template's inactivity_ttl is set (when it's not 0) and when the workspace hasn't seen activity in the last day.

We will use this field to display notifications on the FE about upcoming workspace deletion.

@Kira-Pilot Kira-Pilot requested review from sreya, Emyrk and bpmct May 9, 2023 22:21
@Kira-Pilot Kira-Pilot added this to the Workspace Actions GA milestone May 9, 2023
@sreya sreya changed the title feat: add impending_deletion field to workspace model feat: add deleted_at field to workspace model May 10, 2023
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked the duration nano vs ms. All good!

@Kira-Pilot Kira-Pilot merged commit ae3473d into main May 11, 2023
@Kira-Pilot Kira-Pilot deleted the workspace-impending-deletion/kira-pilot branch May 11, 2023 15:47
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants