Skip to content

feat: update slog to use logfmt #7477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2023
Merged

feat: update slog to use logfmt #7477

merged 9 commits into from
May 14, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented May 10, 2023

Screenshot 2023-05-09 at 7 33 38 PM image

Golden files are updated due to a slight change in lipgloss's behavior in the new version.

Related #7451

ammario added 3 commits May 9, 2023 19:20
So no JSON-dumped complex objects like the workspaceAgent
@ammario ammario force-pushed the slog branch 2 times, most recently from e148b2a to 5c98a7e Compare May 10, 2023 16:09
@ammario ammario requested a review from kylecarbs May 10, 2023 16:11
@ammario ammario enabled auto-merge (squash) May 14, 2023 20:11
@ammario ammario merged commit f05f122 into main May 14, 2023
@ammario ammario deleted the slog branch May 14, 2023 20:23
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants