Skip to content

feat: Add template version warnings #7483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 12, 2023
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 10, 2023

Related: #7452

This PR introduces template version warnings to indicate that a template uses deprecated legacy parameters. Template warnings are implemented in a way that we can use them also for different purposes.

Screenshot 2023-05-11 at 12 37 20 Screenshot 2023-05-11 at 12 37 12

@mtojek mtojek self-assigned this May 10, 2023
@mtojek mtojek requested review from BrunoQuaresma and bpmct May 11, 2023 10:46
@mtojek mtojek marked this pull request as ready for review May 11, 2023 10:46
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE code looks good. Just one minor comment about the "test strategy"

@mtojek mtojek requested a review from BrunoQuaresma May 11, 2023 15:21
@mtojek mtojek enabled auto-merge (squash) May 11, 2023 15:49
@mtojek mtojek force-pushed the 7452-banner-legacy-params branch from f9cc66b to db4b4de Compare May 11, 2023 21:13
@mtojek mtojek force-pushed the 7452-banner-legacy-params branch from 5dc428f to c4d55fc Compare May 12, 2023 06:11
@mtojek mtojek disabled auto-merge May 12, 2023 06:33
@mtojek mtojek enabled auto-merge (squash) May 12, 2023 06:33
@mtojek mtojek force-pushed the 7452-banner-legacy-params branch from c4d55fc to c801d46 Compare May 12, 2023 06:40
@mtojek mtojek merged commit cd38cb8 into coder:main May 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants