Skip to content

chore: Allow cors requests to workspace proxies for latency checks #7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 10, 2023

I had to add this to support my latency check PR. This adds CORs to workspace proxies to allow the primary dashboard to make web requests to it. It only allows GET requets.

@Emyrk Emyrk requested review from a team and mtojek and removed request for a team May 10, 2023 16:48
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emyrk Emyrk enabled auto-merge (squash) May 10, 2023 16:58
@Emyrk Emyrk merged commit 3f9af6f into main May 10, 2023
@Emyrk Emyrk deleted the stevenmasley/proxy_cors_csp branch May 10, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants