chore: improve postgres test time by removing cleanup #7522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to delete databases on cleanup... and we don't need to always run without a cache either!
coadler
approved these changes
May 14, 2023
| -coverpkg=./... \ | ||
| -count=1 -race -failfast |
There was a problem hiding this comment.
Why remove? I think it forces go test to not skip cached tests.
There was a problem hiding this comment.
Go test caching is pretty effective in reducing only duplicates, we use it for the other jobs
Comment on lines
+49
to
+52
| return "postgres://postgres:postgres@127.0.0.1:5432/" + dbName + "?sslmode=disable", func() { | ||
| // We don't need to clean anything up here... it's just a database in a container, | ||
| // so cleaning up the container will clean up the database. | ||
| }, nil |
There was a problem hiding this comment.
is this func only used in ci? would be nice if this only applied in ci so we don't disable cleanup in dogfood.
There was a problem hiding this comment.
Nah, it's used outside too. We just don't need to clean this because it isn't actual waste
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to delete databases on cleanup... and we don't need to always run without a cache either!