Skip to content

fix: Make coder dotfiles symlinking idempotent #7525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

fix: Make coder dotfiles symlinking idempotent #7525

merged 1 commit into from
May 15, 2023

Conversation

spikecurtis
Copy link
Contributor

Fixes: #7427

@spikecurtis
Make coder dotfiles symlinking idempotent
80e32f4 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested a review from a team May 15, 2023 12:06
mtojek
mtojek approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtojek
mtojek approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtojek
mtojek approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtojek
mtojek approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spikecurtis spikecurtis merged commit 0b15642 into main May 15, 2023
@spikecurtis spikecurtis deleted the spike/7427-dotfiles-symlinks branch May 15, 2023 17:00
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder dotfiles errors if symlinks exist; breaks JetBrains Gateway
2 participants
@spikecurtis @mtojek