Skip to content

fix(site): Fix terminal elements size #7527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented May 15, 2023

Fix #7507

Screen Shot 2023-05-15 at 09 25 44

@BrunoQuaresma BrunoQuaresma requested review from bpmct and a team May 15, 2023 12:27
@BrunoQuaresma BrunoQuaresma self-assigned this May 15, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team May 15, 2023 12:27
Comment on lines +326 to +327
You can continue using this terminal, but something may be
missing or not fully set up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more specific error message we can give the user at this point, or no? E.g. "You can continue to use this terminal, but cluster configuration has not yet completed and some functionality may be missing."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to predict what the exact behavior would be, because the startup script is defined by the template admin and in some cases, the user as well. For example, the startup script may be responsible for installing packages, cloning repositories, or setting a default shell. It's best to look at the startup logs (on the workspace page) to see what is still hanging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases where it is still running, it could be as simple as "your shell is bash, not zsh until you refresh" or more important to a workflow such as "the repo hasn't even been cloned yet so you can't start your work"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! Maybe we could prompt the user to look at the startup logs to get a better sense of what's going on.

@BrunoQuaresma BrunoQuaresma merged commit dab1d1f into main May 15, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/terminal-warning branch May 15, 2023 13:48
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"startup script is still running" cuts off bottom of terminal
3 participants