feat: added URL param name to allow setting workspace name #7528
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
734961a to
a6a6683
Compare
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
May 16, 2023
53bdd1f to
4419850
Compare
BrunoQuaresma
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft feature request open for RFC. This PR enables user to set the workspace name field in the CreateWorkspacePageView.
I already talked @BrunoQuaresma about this topic. This is currently untested! But @BrunoQuaresma had look and thinks this is fine.
UseCase
We want to create a workspace from a GitHub repository. We've created an Chrome extension to create a link to open the CreateWorkspacePage. We already pass GitHub owner and GitHub repository to the template via URL parameter. This new parameter name should be filled too.
Follow up
As follow up feature we want add the ability to extend the given workspace name via URL param with a random suffix. This has to be enabled as the default is off. This enables to open multiple workspace instances from the repository at the same time as all workspace names are uniqe. Last but not least we want a feature to skip the confirmation on the CreateWorkspacePage and jump directly to the workspace page.