Skip to content

refactor: workspace builds #7541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 23, 2023
Merged

refactor: workspace builds #7541

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
80e5eb9
refactor workspace builds
spikecurtis May 12, 2023
bd2811f
make gen
spikecurtis May 16, 2023
c892e43
Remove ParameterResolver from typescript
spikecurtis May 16, 2023
25aec4f
rename conversion -> database/db2sdk
spikecurtis May 16, 2023
6d69277
tests for db2sdk
spikecurtis May 17, 2023
817c28e
Tests for ParameterResolver
spikecurtis May 17, 2023
cee21de
wsbuilder tests
spikecurtis May 18, 2023
510a1b0
Move parameter validation tests to richparameters_test.go
spikecurtis May 22, 2023
acd1243
Fix CI generation; rename mock->dbmock
spikecurtis May 23, 2023
5cb2d2a
Fix test imports
spikecurtis May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove ParameterResolver from typescript 
Signed-off-by: Spike Curtis <spike@coder.com>
  • Loading branch information
@spikecurtis
spikecurtis committed May 16, 2023
commit c892e4320faa552be8c5cf322afb786efbb81cce
1 change: 1 addition & 0 deletions codersdk/richparameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ func validationEnabled(param TemplateVersionParameter) bool {
// ParameterResolver should be populated with legacy workload and rich parameter values from the previous build. It then
// supports queries against a current TemplateVersionParameter to determine whether a new value is required, or a value
// correctly validates.
// @typescript-ignore ParameterResolver
type ParameterResolver struct {
Legacy []Parameter
Rich []WorkspaceBuildParameter
Expand Down
6 changes: 0 additions & 6 deletions site/src/api/typesGenerated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,12 +591,6 @@ export interface Parameter {
readonly source_value: string
}

// From codersdk/richparameters.go
export interface ParameterResolver {
readonly Legacy: Parameter[]
readonly Rich: WorkspaceBuildParameter[]
}

// From codersdk/parameters.go
export interface ParameterSchema {
readonly id: string
Expand Down