Skip to content

feat: add impending deletion indicators to the workspace page #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 18, 2023
Merged

feat: add impending deletion indicators to the workspace page #7588

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3691b49
created WorkspaceDeletion directory
Kira-Pilot May 17, 2023
92d0365
remove commented code
Kira-Pilot May 17, 2023
819983c
attempting to fix workspace stories
Kira-Pilot May 17, 2023
8f728bb
fix lint
Kira-Pilot May 17, 2023
e987c70
fix the rest of the stories
Kira-Pilot May 17, 2023
8322b63
fix right stories
Kira-Pilot May 17, 2023
5aec820
PR comments
Kira-Pilot May 18, 2023
d94f9fb
Merge remote-tracking branch 'origin/main' into deletion-indicators-w…
Kira-Pilot May 18, 2023
20ba906
fix lint
Kira-Pilot May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove commented code
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed May 17, 2023
commit 92d036573e333d539f27258fe0cbb5ae32e1e4be
3 changes: 0 additions & 3 deletions site/src/pages/WorkspacesPage/WorkspacesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ export interface WorkspacesPageViewProps {
onPageChange: (page: number) => void
onFilter: (query: string) => void
onUpdateWorkspace: (workspace: Workspace) => void
// allowAdvancedScheduling: boolean
// allowWorkspaceActions: boolean
}

export const WorkspacesPageView: FC<
Expand Down Expand Up @@ -126,7 +124,6 @@ export const WorkspacesPageView: FC<
}
/>
</Maybe>
{/* <DeletionBanner/> determines its own visibility */}
<DeletionBanner
workspace={workspaces?.find((workspace) => workspace.deleting_at)}
displayImpendingDeletionBanner={isNewWorkspacesImpendingDeletion()}
Expand Down