feat(workspaces): change sorting order of the workspace list #7594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
May 19, 2023
johnstcn
approved these changes
May 19, 2023
Co-authored-by: Cian Johnston <cian@coder.com>
mtojek
reviewed
May 22, 2023
There was a problem hiding this comment.
LGTM, but CI complains about some tests:
=== FAIL: coderd TestSortWorkspaces/then_sort_by_last_used_at_(recent_first) (0.00s)
workspaces_internal_test.go:173:
Error Trace: C:/a/coder/coder/coderd/workspaces_internal_test.go:173
Error: Not equal:
expected: []string{"running-userA3", "running-userA2", "running-userA"}
actual : []string{"running-userA3", "running-userA", "running-userA2"}
Diff:
--- Expected
+++ Actual
@@ -2,4 +2,4 @@
(string) (len=14) "running-userA3",
- (string) (len=14) "running-userA2",
- (string) (len=13) "running-userA"
+ (string) (len=13) "running-userA",
+ (string) (len=14) "running-userA2"
}
Test: TestSortWorkspaces/then_sort_by_last_used_at_(recent_first)
Messages: then sort by last used at (recent first)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to the sorting order of the workspace list. The new sorting order is as follows:
That order was suggested in this conversation: #7590 (review).