-
Notifications
You must be signed in to change notification settings - Fork 897
chore: split queries.sql into files by table #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8f65e10
chore: split queries.sql into files by table
coadler b479668
remove underscores from go filenames
coadler 03b8005
queries in one file
coadler 2ef8d8a
install goimports
coadler 7e32318
comment generate.sh
coadler 5aeb544
try go mod tidy
coadler 449abba
mod download instead
coadler 303297c
fix schema
coadler 55476d7
generate.sh comment
coadler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
queries in one file
- Loading branch information
commit 03b80051bbe3ecae17cc4fa5702dec558ddf53ba
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
|
||
cd "$(dirname "$0")" | ||
|
||
sqlc generate | ||
coadler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
first=true | ||
for fi in queries/*.sql.go; do | ||
cut=$(grep -n ')' "$fi" | head -n 1 | cut -d: -f1) | ||
cut=$((cut + 1)) | ||
|
||
if $first; then | ||
head -n 4 < "$fi" | grep -v "source" > queries.sql.go | ||
first=false | ||
fi | ||
|
||
tail -n "+$cut" < "$fi" >> queries.sql.go | ||
done | ||
|
||
rm -f queries/*.go | ||
|
||
goimports -w queries.sql.go | ||
gofmt -w -r 'Querier -> querier' -- *.go | ||
gofmt -w -r 'Queries -> sqlQuerier' -- *.go |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use bash wait to make this faster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest problem is that it has to attempt to install via
npx
every time, otherwise it's pretty fast! Cannpx
be called concurrently?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhhhh. I say we require
sql-formatter
installed globally then.