chore: CORs option for yarn dev server #7630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a flag to set CORs headers to `*` for yarn dev servers
kylecarbs
reviewed
May 22, 2023
coderd/httpmw/cors.go
Outdated
| "net/http" | ||
| ) | ||
|
|
||
| func CorsMW(allowAll bool, origins ...string) func(next http.Handler) http.Handler { |
There was a problem hiding this comment.
Did we not have a CORS MW before?
There was a problem hiding this comment.
Nope. We don't need CORs for the primary coderd, since all web requests are on the same domain.
The issue is the latency request checks for external proxies uses absolute urls. The local yarn dev server runs on a different port. So for the yarn dev server to hit the /latency endpoint, I need to turn on CORs.
This PR blocks all CORs requests to coderd by default if the flag is not true
There was a problem hiding this comment.
This was requested by @BrunoQuaresma. Without it, it was difficult for him to work on the workspace proxy UI.
kylecarbs
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn dev server cannot request latency check endpoint because of CORs and CSP.
Add a flag to allow all external requests for yarn dev server to work correctly. This is a dangerous and hidden flag for dev use only.