feat: add impending deletion banner to workspace page #7634
Conversation
|
@kylecarbs, @bpmct and I would like to know how you feel about this copy. It will probably change a bit when we add a workspace archival component to this feature, but curious if you have initial thoughts. |
This banner should be a lot louder IMO, maybe when days left is <7? Maybe this orphan banner can provide inspiration:
The copy looks good to me. |
|
@ammario I'm hesitant to introduce a new UI pattern, i.e. a new banner style; however I did add some logic to show our 'warning' banner flavor when workspaces will be deleted in 7 days or less so as to convey more urgency. This banner will also be displayed on the |
| !displayImpendingDeletionBanner | ||
| ) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
I found it hard to read/understand this "display or not" logic here. I think the names displayImpendingDeletion and displayImpendingDeletionBanner are very similar and I took some time to understand they are different but not sure how to improve this.
There was a problem hiding this comment.
Ah, let me improve that
|
One comment about this feature overall, maybe would be nice to add a help popover in the "Impending deletion" status explaining what it means. |
resolves #7359