chore: upgrade to golangci-lint 1.52.2 #7674
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
I tried using nix-shell in the context of #4854 but could not get a usable development environment. We need to update our nix-shell setup. Also, we should create an automated way to align all development environments.
|
Nix stuff doesn't appear to have versions pinned at all. So whatever the answer is today, it might not be true tomorrow. |
There was a problem hiding this comment.
Nothing blocking in this PR, so 👍
Nix stuff doesn't appear to have versions pinned at all. So whatever the answer is today, it might not be true tomorrow.
That is correct, but maybe we can check if there is a PR waiting in the nix repo to merge the new version of golangci-lint. Most likely other tools are not aligned too, so maybe we just need to drop support for nix if it's always broken (by design).
golangci-lint 1.52 is out, and it upgrades gocritic, which has dropped the
ioutilDeprecatedchecker. This is because since go 1.19 all the functions in that package are directly marked deprecated, so normal go tooling will pick up on it and the checker is redundant.This PR updates us to latest release of golangci-lint, which was annoying me because my local dev environment has the new version and it complains about this checker being missing.