Skip to content

chore: add mockgen to nix env #7682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

chore: add mockgen to nix env #7682

merged 1 commit into from
May 25, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 25, 2023

This PR adds nix requirement to install mockgen (currently: 1.6.0).

Otherwise:

$ ./scripts/develop.sh
coderd/database/dbmock/doc.go:4: running "mockgen": exec: "mockgen": executable file not found in $PATH
make: *** [Makefile:483: coderd/database/dbmock/store.go] Error 1

@mtojek mtojek requested a review from spikecurtis May 25, 2023 15:44
@mtojek mtojek self-assigned this May 25, 2023
@mtojek mtojek marked this pull request as ready for review May 25, 2023 15:45
@MrPeacockNLB
Copy link
Contributor

I ran just now into this. This fixes dogfooding!

@mtojek mtojek enabled auto-merge (squash) May 25, 2023 16:13
@mtojek mtojek merged commit 5d2b2c5 into coder:main May 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @MrPeacockNLB @coadler