Skip to content

feat(healthcheck): add websocket report #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2023
Merged

feat(healthcheck): add websocket report #7689

merged 8 commits into from
May 30, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 26, 2023

No description provided.

@coadler coadler self-assigned this May 26, 2023
@coadler coadler marked this pull request as ready for review May 30, 2023 17:21
@coadler coadler requested a review from deansheather May 30, 2023 17:21
Comment on lines 85 to 87
c, err := websocket.Accept(rw, r, &websocket.AcceptOptions{})
if err != nil {
httpapi.Write(ctx, rw, http.StatusBadRequest, "Invalid websocket.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should reply with the error from above because it may be useful for debugging e.g. "the host doesn't match origin". And then make the client code read the error

@coadler coadler merged commit 022372d into main May 30, 2023
@coadler coadler deleted the colin/healthcheck-ws branch May 30, 2023 19:22
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants