chore: Buffer remote candidates like local #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added for local candidates, and is required for remote to prevent a race where they are added before a negotiation is complete. I removed the mutex earlier, because it would cause a different race. I didn't realize the remote candidates wouldn't be buffered, but with this change they are!
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 69.04% 71.93% +2.89%
==========================================
Files 84 88 +4
Lines 3256 3421 +165
Branches 55 55
==========================================
+ Hits 2248 2461 +213
+ Misses 825 752 -73
- Partials 183 208 +25
Continue to review full report at Codecov.
|
ammario
approved these changes
Jan 27, 2022
peer/conn.go
Outdated
Comment on lines
309
to
310
| c.localCandidateMutex.Lock() | ||
| defer c.localCandidateMutex.Unlock() |
There was a problem hiding this comment.
I was surprised we didn't need this, but saw it was brought back! I thought there might be cases where ICE candidates could come in, in parallel to negotiate here.
|
Woah so nice to see the green! 🎉 🥳
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added for local candidates, and is required for remote
to prevent a race where they are added before a negotiation is
complete.
I removed the mutex earlier, because it would cause a different race.
I didn't realize the remote candidates wouldn't be buffered,
but with this change they are!