fix: do not skip parameter validation if min or max = 0 #7707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does it look like we need to update the dependency on protoc-gen-go-grpc? |
mafredri
approved these changes
May 30, 2023
| BEGIN; | ||
| ALTER TABLE template_version_parameters ALTER COLUMN validation_min DROP NOT NULL; | ||
| ALTER TABLE template_version_parameters ALTER COLUMN validation_max DROP NOT NULL; | ||
| UPDATE template_version_parameters SET validation_min = NULL WHERE validation_min = 0; |
There was a problem hiding this comment.
Thinking out loud, what if someone has explicitly specified min to be 0 so that -1 can't be used? This seems like a potentially lossy migration and we should probably wait until templates are updated to receive their new, null value?
There was a problem hiding this comment.
It's not worse than what we have today, because we treat min=0 as disabling validation!
There was a problem hiding this comment.
Oh, didn't realize. That's both surprising and worrying, glad it's getting fixed. 😄
| @@ -0,0 +1,6 @@ | |||
| BEGIN; | |||
| UPDATE template_version_parameters SET validation_min = 0 WHERE validation_min = NULL; | |||
| UPDATE template_version_parameters SET validation_max = 0 WHERE validation_max = NULL; | |||
There was a problem hiding this comment.
On the other hand, the lossyness here seems fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #7582
This PR fixes the validation issue which enforced defining
minandmaxtogether for a coder_parameter. Once this is merged,mixandmaxwill be optional and not bound together.