Skip to content

chore: update protoc-gen-go #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 30, 2023
Merged

chore: update protoc-gen-go #7708

merged 7 commits into from
May 30, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 29, 2023 •
edited
Loading

Related: #7707
Related: storj/drpc@8cf1dd2

This PR updates protoc-gen-go libraries to the latest version.

I'm trying to enable support for optional int32 fields, so that we can use *int for validation.min and validation.max.

@mtojek mtojek self-assigned this May 29, 2023
@mtojek mtojek requested review from johnstcn and mafredri May 30, 2023 07:22
@mtojek mtojek marked this pull request as ready for review May 30, 2023 07:22
johnstcn
johnstcn approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mtojek mtojek merged commit 4eb0baa into coder:main May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
mafredri
mafredri reviewed May 30, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we’ve used optionals before, will the update affect those in a non-backwards compatible way?

For instance:

coder/provisioner/terraform/resources.go

Line 156 in 4eb0baa

if _, ok := tfResource.AttributeValues["login_before_ready"]; ok {

Otherwise looks fine 👍

@mtojek
Copy link
Member Author

mtojek commented May 30, 2023

I don't think so, as in my case protoc complained about disabled support for optionals: #7707 (comment) . I don't intend to refactor anything else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri left review comments

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @mafredri @johnstcn