Skip to content

feat: add prometheus metrics to database.Store #7713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 31, 2023
Merged

feat: add prometheus metrics to database.Store #7713

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6c73f9d
feat: add prometheus metrics to database.Store
johnstcn May 30, 2023
c0ea9ef
ensure wrapping
johnstcn May 30, 2023
b153939
only wrap if we have a prometheus registry; add safety check for non-dev
johnstcn May 31, 2023
6b867c6
measure tx duration
johnstcn May 31, 2023
5385657
Merge remote-tracking branch 'origin/main' into cj/db-prom
johnstcn May 31, 2023
d3cf018
fixup! Merge remote-tracking branch 'origin/main' into cj/db-prom
johnstcn May 31, 2023
0ecd6aa
chore: fix flaky TestLicensesListFake/Mainline
johnstcn May 31, 2023
b846d0b
fixup! chore: fix flaky TestLicensesListFake/Mainline
johnstcn May 31, 2023
0b9e836
fix double-wrapping for good
johnstcn May 31, 2023
9aee243
fixup! fix double-wrapping for good
johnstcn May 31, 2023
9367f6a
slices.Contains
johnstcn May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
measure tx duration
  • Loading branch information
@johnstcn
johnstcn committed May 31, 2023
commit 6b867c642c96268f9e1fc71b95ba849a9a31dbdf
16 changes: 14 additions & 2 deletions coderd/database/dbmetrics/dbmetrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,19 @@ func New(s database.Store, reg prometheus.Registerer) database.Store {
Help: "Latency distribution of queries in seconds.",
Buckets: prometheus.DefBuckets,
}, []string{"query"})
txDuration := prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "coderd",
Subsystem: "db",
Name: "tx_duration_seconds",
Help: "Duration of transactions in seconds.",
Buckets: prometheus.DefBuckets,
})
reg.MustRegister(queryLatencies)
reg.MustRegister(txDuration)
return &metricsStore{
s: s,
queryLatencies: queryLatencies,
txDuration: txDuration,
}
}

Expand All @@ -37,6 +46,7 @@ var _ database.Store = (*metricsStore)(nil)
type metricsStore struct {
s database.Store
queryLatencies *prometheus.HistogramVec
txDuration prometheus.Histogram
}

func (m metricsStore) Ping(ctx context.Context) (time.Duration, error) {
Expand All @@ -47,8 +57,10 @@ func (m metricsStore) Ping(ctx context.Context) (time.Duration, error) {
}

func (m metricsStore) InTx(f func(database.Store) error, options *sql.TxOptions) error {
// No point in measuring this, as it's just a wrapper around the underlying store's InTx method.
return m.s.InTx(f, options)
start := time.Now()
err := m.s.InTx(f, options)
m.txDuration.Observe(time.Since(start).Seconds())
return err
}

func (m metricsStore) AcquireLock(ctx context.Context, pgAdvisoryXactLock int64) error {
Expand Down