Skip to content

feat(site): Add proxy menu into navbar #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2023
Merged

feat(site): Add proxy menu into navbar #7715

merged 3 commits into from
May 30, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Demo:

Screen.Recording.2023-05-30.at.10.41.08.mov

Closes #7495

@BrunoQuaresma BrunoQuaresma requested review from Emyrk and a team May 30, 2023 13:43
@BrunoQuaresma BrunoQuaresma self-assigned this May 30, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team May 30, 2023 13:43
Emyrk
Emyrk approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all great.

One thing we might want to add is a button that says like "Use best proxy" and it calls clearProxy on the ContextValue. But we can implement that if it is requested later.

@BrunoQuaresma BrunoQuaresma merged commit c2d2751 into main May 30, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/add-proxies-to-navbar branch May 30, 2023 14:41
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@rodrimaia rodrimaia Awaiting requested review from rodrimaia rodrimaia was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace Proxy UI: Selecting proxy, latency, listing
2 participants
@BrunoQuaresma @Emyrk