Skip to content

ci: Limit scopes with semantic #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022
Merged

ci: Limit scopes with semantic #773

merged 1 commit into from
Mar 31, 2022

Conversation

kylecarbs
Copy link
Member

This should enfore a standardized commit message without a scope.

The repository isn't complex enough to require scopes yet, so we
can punt this down the road!

This should enfore a standardized commit message without a scope.

The repository isn't complex enough to require scopes yet, so we
can punt this down the road!
@kylecarbs kylecarbs self-assigned this Mar 31, 2022
@kylecarbs kylecarbs requested a review from johnstcn March 31, 2022 14:55
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #773 (cc0fb62) into main (f5757ff) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   63.95%   63.96%           
=======================================
  Files         199      199           
  Lines       11826    11826           
  Branches       87       87           
=======================================
+ Hits         7563     7564    +1     
+ Misses       3437     3436    -1     
  Partials      826      826           
Flag Coverage Δ
unittest-go- 63.11% <ø> (-0.03%) ⬇️
unittest-go-macos-latest 58.96% <ø> (+0.09%) ⬆️
unittest-go-ubuntu-latest 61.57% <ø> (-0.21%) ⬇️
unittest-go-windows-2022 58.07% <ø> (+0.03%) ⬆️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/conn.go 76.90% <0.00%> (-2.04%) ⬇️
coderd/workspaceresources.go 56.09% <0.00%> (-1.63%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
provisionerd/provisionerd.go 80.61% <0.00%> (+0.44%) ⬆️
coderd/provisionerdaemons.go 60.03% <0.00%> (+0.50%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+4.80%) ⬆️
pty/start_other.go 88.23% <0.00%> (+23.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5757ff...cc0fb62. Read the comment docs.

@kylecarbs kylecarbs merged commit 1b43a4a into main Mar 31, 2022
@kylecarbs kylecarbs deleted the scopes branch March 31, 2022 15:41
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - happy to help flesh those out down the line as someone that looked after this in v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants