Skip to content

feat: add support for insiders channel to "VS Code Desktop" button #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 31, 2023
Merged

feat: add support for insiders channel to "VS Code Desktop" button #7730

merged 7 commits into from
May 31, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented May 31, 2023 •
edited
Loading

Resolves #6267

@matifali matifali requested a review from BrunoQuaresma May 31, 2023 10:30
@matifali matifali added this to the 🧹 Sprint 0 milestone May 31, 2023
@matifali matifali removed this from the 🧹 Sprint 0 milestone May 31, 2023
@matifali matifali requested review from bpmct, kylecarbs and BrunoQuaresma and removed request for BrunoQuaresma May 31, 2023 12:54
@matifali matifali changed the title feat: support VS Code Insiders feat: add support for insiders channel to "VS Code Desktop" button May 31, 2023
@BrunoQuaresma BrunoQuaresma force-pushed the feat/issue-6267/add-vscode-insiders branch from a2a65de to e596f3a Compare May 31, 2023 14:18
@BrunoQuaresma
Copy link
Collaborator

Changes:

  • I extracted each variant to its own component. Even having some duplication I think it is just easier for now if we want to remove or add one more option. Duplication is not always bad 😃
  • I used a few components from MUI to make it look more "natural" like the ButtonGroup and Menu
  • The problem with the SVG was the "id" conflicts 😅 this one is very annoying

Demo:

Screen.Recording.2023-05-31.at.11.15.05.mov

@BrunoQuaresma BrunoQuaresma self-assigned this May 31, 2023
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) May 31, 2023 16:26
@BrunoQuaresma BrunoQuaresma merged commit b80756e into main May 31, 2023
@BrunoQuaresma BrunoQuaresma deleted the feat/issue-6267/add-vscode-insiders branch May 31, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@bpmct bpmct Awaiting requested review from bpmct

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@BrunoQuaresma BrunoQuaresma

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple vs code channels for "VS Code Desktop" button
2 participants
@matifali @BrunoQuaresma