Skip to content

ci: use Buildjet and faster Windows runners #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2023
Merged

ci: use Buildjet and faster Windows runners #7751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c932c2
chore(ci): downgrade windows runners from 2022 to 2019
ammario Jun 1, 2023
9152539
Move to buildjet
ammario Jun 1, 2023
4de5bae
Buildjet the caches too
ammario Jun 1, 2023
f2e83e2
Change setup actions too
ammario Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 34 additions & 33 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,16 @@ env:

jobs:
lint:
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
steps:
- name: Checkout
uses: actions/checkout@v3

# Install Go!
- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
go-version: ${{ env.CODER_GO_VERSION }}
cache: true

# Check for any typos!
- name: Check for typos
Expand Down Expand Up @@ -69,7 +70,7 @@ jobs:
# Lint our dashboard!
- name: Cache node_modules
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand Down Expand Up @@ -132,15 +133,15 @@ jobs:

gen:
timeout-minutes: 8
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
needs: changes
if: needs.changes.outputs.docs-only == 'false'
steps:
- uses: actions/checkout@v3

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand All @@ -152,7 +153,7 @@ jobs:
- name: Install node_modules
run: ./scripts/yarn_install.sh

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
cache: false
go-version: ${{ env.CODER_GO_VERSION }}
Expand All @@ -164,13 +165,13 @@ jobs:
echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT

- name: Go Build Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOCACHE }}
key: ${{ github.job }}-go-build-${{ hashFiles('**/go.sum', '**/**.go') }}

- name: Go Mod Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOMODCACHE }}
key: ${{ github.job }}-go-mod-${{ hashFiles('**/go.sum') }}
Expand Down Expand Up @@ -220,7 +221,7 @@ jobs:

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand All @@ -244,18 +245,18 @@ jobs:
run: ./scripts/check_unstaged.sh

test-go:
runs-on: ${{ matrix.os == 'ubuntu-latest' && github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'windows-latest-8-cores'|| matrix.os }}
runs-on: ${{ matrix.os == 'ubuntu-latest' && github.repository_owner == 'coder' && 'buildjet-4vcpu-ubuntu-2204' || matrix.os == 'windows-2019' && github.repository_owner == 'coder' && 'windows-latest-8-cores'|| matrix.os }}
timeout-minutes: 20
strategy:
matrix:
os:
- ubuntu-latest
- macos-latest
- windows-2022
- windows-2019
steps:
- uses: actions/checkout@v3

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
cache: false
go-version: ${{ env.CODER_GO_VERSION }}
Expand All @@ -267,13 +268,13 @@ jobs:
echo "GOMODCACHE=$(go env GOMODCACHE)" >> ${{ runner.os == 'Windows' && '$env:' || '$' }}GITHUB_OUTPUT

- name: Go Build Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOCACHE }}
key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.**', '**.go') }}

- name: Go Mod Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOMODCACHE }}
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
Expand Down Expand Up @@ -335,7 +336,7 @@ jobs:
flags: unittest-go-${{ matrix.os }}

test-go-psql:
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
# This timeout must be greater than the timeout set by `go test` in
# `make test-postgres` to ensure we receive a trace of running
# goroutines. Setting this to the timeout +5m should work quite well
Expand All @@ -344,7 +345,7 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
cache: false
go-version: ${{ env.CODER_GO_VERSION }}
Expand All @@ -356,13 +357,13 @@ jobs:
echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT

- name: Go Build Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOCACHE }}
key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum', '**/**.go') }}

- name: Go Mod Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOMODCACHE }}
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
Expand Down Expand Up @@ -413,7 +414,7 @@ jobs:

deploy:
name: "deploy"
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
timeout-minutes: 30
needs: changes
if: |
Expand All @@ -436,7 +437,7 @@ jobs:
- name: Set up Google Cloud SDK
uses: google-github-actions/setup-gcloud@v1

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
cache: false
go-version: ${{ env.CODER_GO_VERSION }}
Expand All @@ -448,20 +449,20 @@ jobs:
echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT

- name: Go Build Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOCACHE }}
key: ${{ runner.os }}-release-go-build-${{ hashFiles('**/go.sum') }}

- name: Go Mod Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOMODCACHE }}
key: ${{ runner.os }}-release-go-mod-${{ hashFiles('**/go.sum') }}

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand Down Expand Up @@ -532,14 +533,14 @@ jobs:
retention-days: 7

test-js:
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v3

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand All @@ -548,7 +549,7 @@ jobs:
restore-keys: |
js-${{ runner.os }}-

- uses: actions/setup-node@v3
- uses: buildjet/setup-node@v3
with:
node-version: "16.16.0"

Expand All @@ -574,21 +575,21 @@ jobs:
needs:
- changes
if: needs.changes.outputs.docs-only == 'false'
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
timeout-minutes: 20
steps:
- uses: actions/checkout@v3

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
.eslintcache
key: js-${{ runner.os }}-e2e-${{ hashFiles('**/yarn.lock') }}

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
cache: false
go-version: ${{ env.CODER_GO_VERSION }}
Expand All @@ -598,7 +599,7 @@ jobs:
terraform_version: 1.1.9
terraform_wrapper: false

- uses: actions/setup-node@v3
- uses: buildjet/setup-node@v3
with:
node-version: "16.16.0"

Expand All @@ -609,13 +610,13 @@ jobs:
echo "GOMODCACHE=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT

- name: Go Build Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOCACHE }}
key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }}

- name: Go Mod Cache
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: ${{ steps.go-cache-paths.outputs.GOMODCACHE }}
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}
Expand Down Expand Up @@ -654,7 +655,7 @@ jobs:
# only get 1 commit on shallow checkout.
fetch-depth: 0

- uses: actions/setup-node@v3
- uses: buildjet/setup-node@v3
with:
node-version: "16.16.0"

Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ env:
jobs:
release:
name: Build and publish
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
env:
# Necessary for Docker manifest
DOCKER_CLI_EXPERIMENTAL: "enabled"
Expand Down Expand Up @@ -98,13 +98,14 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
go-version: ${{ env.CODER_GO_VERSION }}
cache: true

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/security.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:

jobs:
codeql:
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
steps:
- uses: actions/checkout@v3

Expand All @@ -33,7 +33,7 @@ jobs:
languages: go, javascript

- name: Setup Go
uses: actions/setup-go@v4
uses: buildjet/setup-go@v4
with:
go-version: ${{ env.CODER_GO_VERSION }}

Expand All @@ -57,19 +57,20 @@ jobs:
"${{ secrets.SLACK_SECURITY_FAILURE_WEBHOOK_URL }}"

trivy:
runs-on: ${{ github.repository_owner == 'coder' && 'ubuntu-latest-8-cores' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0

- uses: actions/setup-go@v4
- uses: buildjet/setup-go@v4
with:
go-version: ${{ env.CODER_GO_VERSION }}
cache: true

- name: Cache Node
id: cache-node
uses: actions/cache@v3
uses: buildjet/cache@v3
with:
path: |
**/node_modules
Expand Down