Skip to content

ci: deduplicate language setup #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023
Merged

ci: deduplicate language setup #7753

merged 2 commits into from
Jun 1, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Jun 1, 2023

Previously, we were duplicating large portions of each job with language setup and caching. This change organizes the boilerplate into reusable, composite actions.

Also, this change splits up the go-psql test into go-pg and go-race. go-psql was a misnomer because it also ran the race detector. With the split we can take better advantage of CI concurrency and the workflow should complete faster.

@ammario ammario changed the title ci: deduplicate Go actions ci: deduplicate language setup Jun 1, 2023
@ammario ammario marked this pull request as ready for review June 1, 2023 07:46
@matifali
Copy link
Member

matifali commented Jun 1, 2023

This makes the ci code concise and more maintainable. Awesome job @ammario.

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github actions setup LGTM 👍

Screenshot 2023-06-01 at 10 05 23

I guess that this glitch will require admin rights to merge the PR?

@ammario
Copy link
Member Author

ammario commented Jun 1, 2023

@mtojek I just need to update the repo settings before I merge.

@ammario ammario enabled auto-merge (squash) June 1, 2023 08:08
@ammario ammario merged commit 555ea64 into main Jun 1, 2023
@ammario ammario deleted the ci-split-race branch June 1, 2023 08:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants