Skip to content

fix: use minDisabled, maxDisabled for parameter validation #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 2, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jun 1, 2023

Fixes: #7582

This PR adjusts the parameter validation to be aligned with recent changes in the terraform-provider-coder - MinDisabled and MaxDisabled fields.

@mtojek mtojek self-assigned this Jun 1, 2023
@mtojek mtojek marked this pull request as ready for review June 1, 2023 11:44
@mtojek mtojek requested a review from spikecurtis June 1, 2023 11:58
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions for interesting test cases, but LGTM.

@mtojek mtojek changed the title fix: use MinDisabled, MaxDisabled for parameter validation fix: use minDisabled, maxDisabled for parameter validation Jun 2, 2023
@mtojek mtojek merged commit 10036ab into coder:main Jun 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Parameter validation is skipped if min or max is 0.
2 participants