chore: add function to refetch latencies to ProxyContext #7769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
site/src/contexts/useProxyLatency.ts
Outdated
| // This fetchNumber is used to trigger a refetch of the proxy latencies. | ||
| const [fetchNumber, setFetchNumber] = useState(0) | ||
| const refetch = (): void => { | ||
| setFetchNumber(fetchNumber + 1) |
There was a problem hiding this comment.
this name is ok, but I would do something like this:
const [latestFetchRequest, setLatestFetchRequest] = useState(new Date().toISOString())
const refetch = () => {
setLatestFetchRequest(new Date().toISOString())
}
I think this is a bit better because we can display the latest time the latency was checked if we want to and the naming is easier to reason about but it is up to you.
There was a problem hiding this comment.
Each latency report has the date it was checked. I was thinking about adding an integer counter so the FE can tell if the latency provided is the latest one requested. But I figured if we want to add UI flair, we can implement it then.
I will update the name, and make it a date, but won't do anything with the date for now.
BrunoQuaresma
approved these changes
Jun 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button when clicked is async, so maybe we need to add some sort of loading wheel or something?