Skip to content

hotfix: initial options as empty array #7782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Jun 1, 2023

This could cause a major UI error if the options are not returned for any reason like a wrong filter or any issue in the endpoint. It is still an error but those errors should be handled "locally" in the component instead. I noticed that when playing around with a few endpoints.

@BrunoQuaresma BrunoQuaresma self-assigned this Jun 1, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines
  • ✅ Title matches ^hotfix(\(.+\))?:.*$

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) June 1, 2023 18:17
@BrunoQuaresma BrunoQuaresma merged commit 0f439d5 into main Jun 1, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/hotfix-autocomplete branch June 1, 2023 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant