feat(provisioner): add support for .tf.json templates #7835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Jun 4, 2023
|
@coadler feedback welcome, I tried to match my changes to your previous changes :) |
|
@coadler can you take a look here |
|
Hey @TECHNOFAB11, I edited this a bit to add some more tests. Was wondering if you could give me permission to push to your branch! |
|
@coadler sure, I'm not sure if I forgot to check the box to allow edits or something but I added you as a collaborator, I hope that works too :) |
coadler
approved these changes
Jun 7, 2023
deansheather
approved these changes
Jun 7, 2023
|
Thank you for your contribution! |
|
Yes, thanks a ton @TECHNOFAB11! |
|
Thank you all for the amazing project! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick draft to extend #7744 to support .tf.json for rich parameters.
This uses hclparse's
ParseJSONFilemethod on .tf.json files as a "replacement" forParseHCLFile, so the output is identical.Context
Original issue: #7700
Revert because of missing rich parameter support: #7829