Skip to content

refactor(site): give default error message when description is missing #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Having the stack trace displayed in the alert does not look good and I think it is not helpful at all so I just updated the message to something more friendly.

Before:
Screen Shot 2023-06-05 at 10 14 04

After:
Screen Shot 2023-06-05 at 10 12 36

@BrunoQuaresma BrunoQuaresma requested a review from a team June 5, 2023 13:18
@BrunoQuaresma BrunoQuaresma self-assigned this Jun 5, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team June 5, 2023 13:18
@ammario ammario changed the title refactor(site): default error message when there is no description refactor(site): give default error message when description is missing Jun 5, 2023
@BrunoQuaresma BrunoQuaresma requested a review from Kira-Pilot June 5, 2023 17:46
@BrunoQuaresma BrunoQuaresma merged commit b9e3226 into main Jun 5, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-message branch June 5, 2023 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants