Skip to content

fix: Build site in release process #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix: Build site in release process #785

merged 1 commit into from
Mar 31, 2022

Conversation

kylecarbs
Copy link
Member

The static site wasn't building prior, so authenticating via CLI was broken!

@kylecarbs kylecarbs requested a review from bpmct March 31, 2022 18:28
@kylecarbs kylecarbs self-assigned this Mar 31, 2022
@kylecarbs kylecarbs changed the title release: Build site in build process correct: Build site in build process Mar 31, 2022
The static site wasn't building prior, so authenticating via CLI was broken!
@kylecarbs kylecarbs changed the title correct: Build site in build process fix: Build site in release process Mar 31, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) March 31, 2022 18:30
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #785 (5e50146) into main (50f2fca) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   64.18%   63.92%   -0.27%     
==========================================
  Files         199      199              
  Lines       11830    11830              
  Branches       87       87              
==========================================
- Hits         7593     7562      -31     
- Misses       3419     3441      +22     
- Partials      818      827       +9     
Flag Coverage Δ
unittest-go- 63.10% <ø> (-0.13%) ⬇️
unittest-go-macos-latest 58.72% <ø> (-0.30%) ⬇️
unittest-go-ubuntu-latest 61.85% <ø> (-0.16%) ⬇️
unittest-go-windows-2022 58.05% <ø> (-0.04%) ⬇️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
codersdk/provisionerdaemons.go 58.46% <0.00%> (-6.16%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
coderd/workspaceresources.go 57.72% <0.00%> (-3.26%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
peer/conn.go 78.93% <0.00%> (-1.78%) ⬇️
provisionerd/provisionerd.go 80.17% <0.00%> (-0.89%) ⬇️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f2fca...5e50146. Read the comment docs.

@kylecarbs kylecarbs merged commit b226103 into main Mar 31, 2022
@kylecarbs kylecarbs deleted the siterelease branch March 31, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants