fix: ignore case while sorting usernames #7870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jun 6, 2023
| @@ -933,7 +933,7 @@ func (q *fakeQuerier) GetUsers(_ context.Context, params database.GetUsersParams | |||
|
|
|||
| // Database orders by username | |||
| slices.SortFunc(users, func(a, b database.User) bool { | |||
| return a.Username < b.Username | |||
| return strings.ToLower(a.Username) < strings.ToLower(b.Username) | |||
There was a problem hiding this comment.
I hope not, but can we have multiple users named the same? ZeroCool, zerocool, Zerocool and zeroCool. So that we'd need to handle lower(a) == lower(b) case?
There was a problem hiding this comment.
Fortunately: User already exists. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #7838 doesn't ignore casing while sorting usernames, so this PR fixes it.
Currently: