chore: make default workspace proxy editable #7903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jun 7, 2023
| if err != nil { | ||
| httpapi.InternalServerError(rw, err) | ||
| return | ||
| } | ||
|
|
||
| var updatedProxy database.WorkspaceProxy | ||
| if proxy.ID.String() == deploymentIDStr { |
There was a problem hiding this comment.
Since the code for this route is completely different for primary and other proxies, could you register it as a different route on the handler? like PUT /api/v2/proxies/primary, PUT /api/v2/proxies/${deployment_id}, and PUT /api/v2/proxies/:other_id.
There was a problem hiding this comment.
Interesting idea. I can try it.
There was a problem hiding this comment.
I factored it out into it's own function. It's own route got a bit tricky since I had to duplicate route blocks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7718
How it works
Stores the display name and icon url in the
site_configstable. The other proxy fields are computed and not able to be changed.Extra
wsproxy lsnow includes the default.