Skip to content

fix(cli/help): show deprecation notice properly for flags #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2023
Merged

fix(cli/help): show deprecation notice properly for flags #7904

merged 3 commits into from
Jun 8, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 7, 2023 •
edited
Loading

This looked odd before, could be mistaken for pointing at the next flag, and was surrounded by a single space in front and behind. Definitely looked like a bug.

Old output format: 5e8c487#diff-512004ca076a52e21bb5d1fd4a724e99c236cd75b9a6859d1a501c60f77d7ac6R31

New output format:

+++ cli/testdata/coder_ssh_--help.golden
@@ -30,6 +30,7 @@ Start a shell into a workspace
           blocking). Note that the workspace agent may still be in the process
           of executing the startup script and the workspace may be in an
           incomplete state.
+          DEPRECATED: Use --wait, --other and --third instead.

@mafredri mafredri self-assigned this Jun 7, 2023
@mafredri mafredri requested a review from ammario June 7, 2023 15:48
@mafredri mafredri changed the title fix(cli/help): Show deprecation notice properly for flags fix(cli/help): show deprecation notice properly for flags Jun 7, 2023
@mafredri mafredri enabled auto-merge (squash) June 8, 2023 14:06
@mafredri mafredri merged commit fa91e11 into main Jun 8, 2023
@mafredri mafredri deleted the mafredri/fix-clibase-deprecated-flag branch June 8, 2023 14:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @ammario