Skip to content

docs: add RStudio community template without requiring a subdomain #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2023
Merged

docs: add RStudio community template without requiring a subdomain #7909

merged 3 commits into from
Jun 8, 2023

Conversation

atnomoverflow
Copy link
Contributor

No description provided.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@atnomoverflow atnomoverflow changed the title adding a rstudio without using subdomain comunity template docs(templates):adding a rstudio without using subdomain comunity template Jun 7, 2023
@atnomoverflow
Copy link
Contributor Author

atnomoverflow commented Jun 7, 2023 •
edited
Loading

I have read the CLA Document and I hereby sign the CLA

@coadler
Copy link
Contributor

coadler commented Jun 7, 2023

@atnomoverflow You need to comment just I have read the CLA Document and I hereby sign the CLA and nothing else!

@atnomoverflow
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Jun 7, 2023
@cdrcommunity
@atnomoverflow has signed the CLA in coder/coder#7909
c63071e
@matifali
Copy link
Member

matifali commented Jun 8, 2023

Hi @atnomoverflow, Thanks for the contribution. The fmt test is failing, Is it ok if I format by pushing directly to the branch?

@matifali matifali changed the title docs(templates):adding a rstudio without using subdomain comunity template docs(templates): add RStudio community template without requiring a subdomain Jun 8, 2023
@matifali matifali changed the title docs(templates): add RStudio community template without requiring a subdomain docs(templates/community-templates): add RStudio community template without requiring a subdomain Jun 8, 2023
@matifali matifali changed the title docs(templates/community-templates): add RStudio community template without requiring a subdomain docs: add RStudio community template without requiring a subdomain Jun 8, 2023
@atnomoverflow
Copy link
Contributor Author

atnomoverflow commented Jun 8, 2023 •
edited
Loading

@matifali sure!

@atnomoverflow
Copy link
Contributor Author

@matifali there are some improvment that can be done to what i did like

  • The rstudio can be served at a subpath on the nginx so that you can resuse the nginx .
  • You can also create a config map and mount it on the pod but you will have to use sub env to change the redirect uri.

@matifali matifali enabled auto-merge (squash) June 8, 2023 08:56
auto-merge was automatically disabled June 8, 2023 12:33

Head branch was pushed to by a user without write access

@matifali matifali enabled auto-merge (squash) June 8, 2023 12:36
@matifali matifali disabled auto-merge June 8, 2023 12:36
@matifali matifali enabled auto-merge (squash) June 8, 2023 12:37
@matifali matifali merged commit 4794674 into coder:main Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@atnomoverflow atnomoverflow

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atnomoverflow @coadler @matifali