Skip to content

ci: move timing tests to nightly gauntlet #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2023
Merged

ci: move timing tests to nightly gauntlet #7910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a69a1d
ci: move timing tests to nightly gauntlet
ammario Jun 7, 2023
efad078
fixup! ci: move timing tests to nightly gauntlet
ammario Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/nightly-flake.yaml → .github/workflows/nightly-gauntlet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name: nightly-flake
# The nightly-gauntlet runs tests that are either too flaky or too slow to block
# every PR.
name: nightly-gauntlet
on:
schedule:
# Every day at midnight
- cron: "0 0 * * *"
workflow_dispatch:
# For testing purposes
# push:
# paths:
# - ".github/workflows/nightly-flake.yaml"
push:
branch:
- nightly-gauntlet
jobs:
test-go-race:
go-race:
# While GitHub's toaster runners are likelier to flake, we want consistency
# between this environment and the regular test environment for DataDog
# statistics and to only show real workflow threats.
Expand Down Expand Up @@ -38,3 +39,20 @@ jobs:
if: always()
with:
api-key: ${{ secrets.DATADOG_API_KEY }}

go-timing:
# We run these tests with p=1 so we don't need a lot of compute.
runs-on: "buildjet-2vcpu-ubuntu-2204"
timeout-minutes: 10
steps:
- uses: actions/checkout@v3

- uses: ./.github/actions/setup-go
- name: Run Tests
run: |
gotestsum --junitfile="gotests.xml" -- --tags="timing" -p=1 -run='_Timing/' ./...

- uses: ./.github/actions/upload-datadog
if: always()
with:
api-key: ${{ secrets.DATADOG_API_KEY }}
1 change: 1 addition & 0 deletions scaletest/agentconn/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ func Test_Runner(t *testing.T) {

//nolint:paralleltest // Measures timing as part of the test.
func Test_Runner_Timing(t *testing.T) {
testutil.SkipIfNotTiming(t)
//nolint:paralleltest
t.Run("Direct+Hold", func(t *testing.T) {
client, agentID := setupRunnerTest(t)
Expand Down