Skip to content

test(agent/agentssh): close SSH servers in all tests #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

test(agent/agentssh): close SSH servers in all tests #7911

merged 1 commit into from
Jun 7, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Jun 7, 2023

@ammario ammario added the hotfix label Jun 7, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Jun 7, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ammario ammario enabled auto-merge (squash) June 7, 2023 23:28
@ammario ammario force-pushed the hotfix-agentssh-tests branch from 679910f to 9f31816 Compare June 7, 2023 23:29
@ammario ammario changed the title test(agent/agentssh): close servers consistently test(agent/agentssh): always close SSH servers Jun 7, 2023
@ammario ammario changed the title test(agent/agentssh): always close SSH servers test(agent/agentssh): close SSH servers in all tests Jun 7, 2023
@ammario ammario disabled auto-merge June 7, 2023 23:32
@ammario ammario enabled auto-merge (squash) June 7, 2023 23:32
@ammario ammario merged commit fcca639 into main Jun 7, 2023
@ammario ammario deleted the hotfix-agentssh-tests branch June 7, 2023 23:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ammario