Skip to content

docs(admin/workspace-proxies): add instructions to run using the Docker image #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 9, 2023
Merged

docs(admin/workspace-proxies): add instructions to run using the Docker image #7915

merged 6 commits into from
Jun 9, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jun 8, 2023 •
edited
Loading

Add instructions to change the entrypoint of the image when running as a workspace proxy.

@matifali matifali requested a review from deansheather June 8, 2023 12:32
@matifali matifali changed the title docs(admin/workspace-proxies): add instructions to run using the Docker image. docs(admin/workspace-proxies): add instructions to run using the Docker image Jun 8, 2023
@matifali matifali requested a review from Emyrk June 9, 2023 07:11
@matifali matifali enabled auto-merge (squash) June 9, 2023 07:11
deansheather

This comment was marked as outdated.

Sign in to view

@matifali matifali requested review from deansheather and removed request for Emyrk June 9, 2023 11:36
deansheather
deansheather reviewed Jun 9, 2023
View reviewed changes
@deansheather deansheather requested a review from ammario June 9, 2023 11:38
@matifali @deansheather
Apply suggestions from code review
f136975 
Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifali
Copy link
Member Author

matifali commented Jun 9, 2023

Thank you for the valuable feedback.

@matifali matifali requested a review from deansheather June 9, 2023 11:43
@deansheather
Copy link
Member

Ammar or someone who maintains docs can check the final wording.

@deansheather deansheather removed their request for review June 9, 2023 11:44
@deansheather deansheather dismissed their stale review June 9, 2023 11:44

outdated

@matifali matifali requested a review from Emyrk June 9, 2023 11:45
Emyrk
Emyrk reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is great to reuse the existing docker container

Emyrk
Emyrk approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to merge and we can update language later. It's still experimental and we probably need to review all the language around this feature.

@matifali matifali merged commit 16ebe10 into main Jun 9, 2023
@matifali matifali deleted the wsproxy-docker-image-docs branch June 9, 2023 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather left review comments

@Emyrk Emyrk Emyrk approved these changes

@ammario ammario Awaiting requested review from ammario

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matifali @deansheather @Emyrk