fix(codersdk): handle API older than client for startup script behavior #7933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Jun 9, 2023
| @@ -1126,7 +1126,7 @@ func convertWorkspaceAgent(derpMap *tailcfg.DERPMap, coordinator tailnet.Coordin | |||
| ConnectionTimeoutSeconds: dbAgent.ConnectionTimeoutSeconds, | |||
| TroubleshootingURL: troubleshootingURL, | |||
| LifecycleState: codersdk.WorkspaceAgentLifecycle(dbAgent.LifecycleState), | |||
| LoginBeforeReady: dbAgent.StartupScriptBehavior == database.StartupScriptBehaviorNonBlocking, | |||
| LoginBeforeReady: dbAgent.StartupScriptBehavior != database.StartupScriptBehaviorBlocking, | |||
There was a problem hiding this comment.
Not a necessary change, but this seems safer (default to old behavior) vs default to new in case something goes wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regrettably, I didn't think about this case when creating the PRs for startup script behavior. If the API is older than the client, then the field may be missing. We now handle it in
codersdk.