Skip to content

feat: add disabling of default 'everyone' group access to template #7982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 14, 2023
Merged

feat: add disabling of default 'everyone' group access to template #7982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a21f319
feat: add disabling of default 'everyone' group access to template
Emyrk Jun 12, 2023
8dd7e5f
add unit test
Emyrk Jun 12, 2023
ec47f50
add FE to disable everyone group
Emyrk Jun 12, 2023
0a3f679
require entitlement to uncheck box
Emyrk Jun 12, 2023
bef008a
Merge remote-tracking branch 'origin/main' into stevenmasley/disable_…
Emyrk Jun 12, 2023
6ed8a91
Fix wording
Emyrk Jun 12, 2023
91b015b
Wording
Emyrk Jun 12, 2023
e1bfab9
Update golden files
Emyrk Jun 12, 2023
a0578f3
remove debug code
Emyrk Jun 12, 2023
911018f
Change wording from PR suggestion
Emyrk Jun 13, 2023
25e9ece
Merge remote-tracking branch 'origin/main' into stevenmasley/disable_…
Emyrk Jun 13, 2023
244ab36
Merge remote-tracking branch 'origin/main' into stevenmasley/disable_…
Emyrk Jun 13, 2023
7359db2
Update golden files
Emyrk Jun 13, 2023
678171f
update golden files
Emyrk Jun 13, 2023
62c0d82
Update site/src/pages/CreateTemplatePage/CreateTemplateForm.tsx
Emyrk Jun 14, 2023
340b8b2
Drop some wording
Emyrk Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change wording from PR suggestion
  • Loading branch information
@Emyrk
Emyrk committed Jun 13, 2023
commit 911018f4f964184bd92dabf1bda352f784cb3016
2 changes: 1 addition & 1 deletion cli/templatecreate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func (r *RootCmd) templateCreate() *clibase.Cmd {
}
cmd.Options = clibase.OptionSet{
{
Flag: "disable-everyone",
Flag: "private",
Description: "Disable the default behavior of granting template access to the 'everyone' group. " +
"The template permissions must be updated to allow non-admin users to use this template.",
Value: clibase.BoolOf(&disableEveryone),
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/CreateTemplatePage/CreateTemplateForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,9 @@ export const CreateTemplateForm: FC<CreateTemplateFormProps> = ({
</FormFields>
</FormSection>

{/* Operations */}
{/* Permissions */}
<FormSection
title="Operations"
title="Permissions"
description="Regulate actions allowed on workspaces created from this template."
>
<Stack direction="column">
Expand Down