Skip to content

chore: generate and order dbfake funcs automatically #7986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 12, 2023

It sucks to copy the syntax everywhere! This automatically stubs out new funcs on make gen and orders them the same as the interface.

The large diff is because of the ordering of dbfake... there's ~300 lines of actual contribution.

@kylecarbs kylecarbs requested a review from coadler June 12, 2023 21:18
@kylecarbs kylecarbs marked this pull request as ready for review June 12, 2023 21:18
@kylecarbs kylecarbs changed the title chore: automatically order and generate dbfake funcs chore: generate and order dbfake funcs automatically Jun 12, 2023
@kylecarbs kylecarbs merged commit 28f3539 into main Jun 12, 2023
@kylecarbs kylecarbs deleted the dbfakegen branch June 12, 2023 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants