Skip to content

feat: add example grafana dashboard #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2023
Merged

feat: add example grafana dashboard #7987

merged 4 commits into from
Jun 13, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jun 12, 2023

Closes #6154

@coadler coadler self-assigned this Jun 12, 2023
@coadler coadler requested a review from kylecarbs June 12, 2023 22:17
kylecarbs
kylecarbs approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should get @bpmct to stamp!

@coadler coadler requested a review from bpmct June 12, 2023 22:18
bpmct
bpmct reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should also include a graph of provisioner jobs over time, as this can surface peak hours (autostart) and can also be used to tune provisioner count, and identify cause for high CPU and DB usage.

Edit. I totally missed "concurrent jobs"

@bpmct bpmct merged commit f2758fc into main Jun 13, 2023
@bpmct bpmct deleted the colin/grafana branch June 13, 2023 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Grafana dashboard
3 participants
@coadler @kylecarbs @bpmct