Skip to content

chore: remove cache from fmt to save time #8001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

chore: remove cache from fmt to save time #8001

merged 1 commit into from
Jun 13, 2023

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs self-assigned this Jun 13, 2023
@kylecarbs kylecarbs force-pushed the fasterfmt branch 5 times, most recently from c74e7f2 to 865f35e Compare June 13, 2023 15:20
@kylecarbs kylecarbs changed the title chore: try removing cache from fmt and lint chore: remove cache from fmt to save time Jun 13, 2023
@kylecarbs kylecarbs requested a review from ammario June 13, 2023 15:25
@kylecarbs kylecarbs marked this pull request as ready for review June 13, 2023 15:25
Emyrk
Emyrk approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"remove cache to save time"

Me wondering how a cache can slow things down 🤔. Lol

@kylecarbs
Copy link
Member Author

@Emyrk the node cache is disgustingly large

@Emyrk
Copy link
Member

Emyrk commented Jun 13, 2023

9i6bs4g6cx05jeagfhum

@kylecarbs kylecarbs merged commit 75078fa into main Jun 13, 2023
@kylecarbs kylecarbs deleted the fasterfmt branch June 13, 2023 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
@matifali
Copy link
Member

Thanks @kylecarbs ❤️
fmt now runs in under 30 seconds.
https://github.com/coder/coder/actions/runs/5266730236/jobs/9521043742

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@ammario ammario Awaiting requested review from ammario

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @Emyrk @matifali