Skip to content

chore: remove key comparison check to fix gitsshkey flake #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

kylecarbs
Copy link
Member

In tests we use weak randomness and the same key was generated which caused a test flake here.

In tests we use weak randomness and the same key was generated which
caused a test flake here.
@kylecarbs kylecarbs requested a review from coadler June 13, 2023 15:45
@kylecarbs kylecarbs self-assigned this Jun 13, 2023
@kylecarbs kylecarbs marked this pull request as ready for review June 13, 2023 15:45
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@kylecarbs kylecarbs enabled auto-merge (squash) June 13, 2023 15:48
@kylecarbs kylecarbs merged commit 2495386 into main Jun 13, 2023
@kylecarbs kylecarbs deleted the gitsshflake branch June 13, 2023 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants