Skip to content

fix: scope errors to subtests to reduce flake #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: scope errors to subtests to reduce flake #8004

merged 1 commit into from
Jun 13, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from Emyrk June 13, 2023 16:30
@kylecarbs kylecarbs self-assigned this Jun 13, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Jun 13, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@kylecarbs kylecarbs changed the title fix: scope errors to subtests for flake fix: scope errors to subtests to reduce flake Jun 13, 2023
@kylecarbs kylecarbs merged commit 2e7e99b into main Jun 13, 2023
@kylecarbs kylecarbs deleted the flakerace branch June 13, 2023 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylecarbs