Skip to content

feat(site): add documentation links to webterminal notifications #8019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2023
Merged

feat(site): add documentation links to webterminal notifications #8019

merged 2 commits into from
Jun 14, 2023

Conversation

rodrimaia
Copy link
Contributor

Fixes #7760 and #7766

  • refactor web terminal notifications to their own component, leveraging the existing component Alert
  • create stories for the new component
  • changed notifications to be dismissable
  • changed notifications copy and links to documentation
  • added code to detect and display a notification for when the startup script finishes running successfully

updated notifications:
image
image

new notification:
image

@rodrimaia rodrimaia self-assigned this Jun 13, 2023
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jun 13, 2023
@rodrimaia rodrimaia linked an issue Jun 13, 2023 that may be closed by this pull request
Improve startup script notification in web terminal with troubleshooting link and status update #7766
Closed
3 tasks
BrunoQuaresma
BrunoQuaresma approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things:

  • I would remove the border-radius from the alert. It looks strange to have it when it is full-width.
  • I would make the "refresh session" button a text variant to look better and maybe remove the icon.

@rodrimaia rodrimaia enabled auto-merge (squash) June 14, 2023 00:26
@rodrimaia rodrimaia merged commit 1da2570 into main Jun 14, 2023
@rodrimaia rodrimaia deleted the improve_terminal_startup_notification branch June 14, 2023 00:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
@ammario ammario removed the community Pull Requests and issues created by the community. label Jun 14, 2023
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jun 14, 2023
@ammario ammario removed the community Pull Requests and issues created by the community. label Jun 14, 2023
@mtojek
Copy link
Member

mtojek commented Jun 14, 2023 •
edited
Loading

@bpmct Feel free to take a look and review the UX/messaging side 👍

@bpmct
Copy link
Member

bpmct commented Jun 20, 2023

Copy LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@mafredri mafredri Awaiting requested review from mafredri

@Kira-Pilot Kira-Pilot Awaiting requested review from Kira-Pilot

Assignees

@rodrimaia rodrimaia

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@rodrimaia @mtojek @bpmct @BrunoQuaresma @ammario