Skip to content

fix: only collect prometheus database metrics when explicitly enabled #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2023
Merged

fix: only collect prometheus database metrics when explicitly enabled #8045

merged 3 commits into from
Jun 15, 2023

Conversation

johnstcn
Copy link
Member

This PR adds a new configuration knob --prometheus-collect-db-metrics / CODER_PROMETHEUS_COLLECT_DB_METRICS which defaults to false.
Coder's database.Store will only be wrapped with dbmetrics.New if this is explicitly enabled.

@johnstcn johnstcn self-assigned this Jun 15, 2023
deansheather
deansheather reviewed Jun 15, 2023
View reviewed changes
@johnstcn johnstcn requested a review from deansheather June 15, 2023 11:10
@johnstcn johnstcn merged commit 6e59823 into main Jun 15, 2023
@johnstcn johnstcn deleted the cj/dbmetrics-optin branch June 15, 2023 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

@coadler coadler Awaiting requested review from coadler

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @deansheather