fix(agent): refactor trackScriptLogs to avoid deadlock
#8084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c9c1ad to
fe53927
Compare
trackScriptLogs to avoid deadlocktrackScriptLogs to avoid deadlock
fe53927 to
2798ecd
Compare
mtojek
approved these changes
Jun 20, 2023
Base automatically changed from
mafredri/refactor-startup-script-eof-to-start-end
to
main
June 20, 2023 11:41
During agent close it was possible for the startup script logs consumer to enter a deadlock state where by agent close was waiting via `a.trackConnGoroutine` and the log reader for a flush event. This refactor removes the mutex in favor of channel communication and relies on two goroutines without shared state.
2798ecd to
3913854
Compare
6f66e6e to
78c478c
Compare
Sure, I can take a stab at it! 👍🏻 |
|
I'll merging this now and submit a separate PR which breaks this up into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During agent close it was possible for the startup script logs consumer
to enter a deadlock state where by agent close was waiting via
a.trackConnGoroutineand the log reader for a flush event.This refactor removes the mutex in favor of channel communication and
relies on two goroutines without shared state.
https://github.com/coder/coder/actions/runs/5313851600/jobs/9620310022?pr=8082
NOTE: Observe PR target is not
main.